Re: [PATCH 2/2] update cg-* to use cg-Xignore
- From
Petr Baudis <pasky@ucw.cz>
- Date
- May 14, 2005, 12:18 UTC
- Message-ID
- <20050514121846.GE3905@pasky.ji.cz>
- In-Reply-To
- <4285B5CA.8060106@dgreaves.com>
Dear diary, on Sat, May 14, 2005 at 10:24:42AM CEST, I got a letter where David Greaves <david@dgreaves.com> told me that...
Show 23 quoted lines
> Petr Baudis wrote: > > >Dear diary, on Sat, May 14, 2005 at 12:32:22AM CEST, I got a letter > >where David Greaves <david@dgreaves.com> told me that... > > > > > >>Updated > >> cg-add > >> cg-commit > >> > >> > > > >I consider this Bad Thing (tm). Or could you please point a situation > >where this would be actually useful? If you explicitly cg-add, you > >likely know what are you doing, and same thing with cg-commit - if it's > >already added, it should be watches, no matter what ignore patterns, I > >think. > > > > > OK, lets say I'm clever and know what an ignore pattern is. > I can > find * | xargs cg-add > my laziness something my hubris acknowledges :)
Makes sense, ok.
What about cg-commit? You already even added it.
Show 29 quoted lines
> >>Index: cg-status
> >>===================================================================
> >>--- d2490ad0bc8b38647c6baff9da3e72c0f25e9f35/cg-status (mode:100755)
> >>+++ 03662df7d089d4a84987ef9edb50a017b8b42439/cg-status (mode:100755)
> >>@@ -15,21 +15,11 @@
> >>
> >> {
> >> git-ls-files -z -t --others --deleted --unmerged $EXCLUDE
> >>-} | sort -z -k 2 | xargs -0 sh -c '
> >>-while [ "$1" ]; do
> >>- tag=${1% *};
> >>- filename=${1#* };
> >>- case "$filename" in
> >>- *.[ao] | tags | ,,merge*) ;;
> >>- *) echo "$tag $filename";;
> >>- esac
> >>- shift
> >>-done
> >>-' padding
> >>+} | sort -z -k 2 | cg-Xignore -0 -t | tr "\000" "\n"
> >>
> >>
> >
> >So you have two ignores now - exclude and Xignore.
> >
> >
> No, cogito has an ignore.
> git has a less powerful exclude.
> cogito users won't need exclude but power-users aren't barred from it.I think having two essentially redundant things is useless. But you'll be able to use the --exclude powers now since you have to fall back to good ol' globs.
-- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor