Re: [PATCH 2/2] update cg-* to use cg-Xignore
- From
Petr Baudis <pasky@ucw.cz>
- Date
- May 13, 2005, 22:55 UTC
- Message-ID
- <20050513225516.GG32232@pasky.ji.cz>
- In-Reply-To
- <E1DWihi-0007DQ-SD@ash.dgreaves.com>
Dear diary, on Sat, May 14, 2005 at 12:32:22AM CEST, I got a letter where David Greaves <david@dgreaves.com> told me that...
> Updated > cg-add > cg-commit
I consider this Bad Thing (tm). Or could you please point a situation where this would be actually useful? If you explicitly cg-add, you likely know what are you doing, and same thing with cg-commit - if it's already added, it should be watches, no matter what ignore patterns, I think.
Show 18 quoted lines
> --- d2490ad0bc8b38647c6baff9da3e72c0f25e9f35/cg-commit (mode:100755)
> +++ 03662df7d089d4a84987ef9edb50a017b8b42439/cg-commit (mode:100755)
> @@ -65,6 +65,15 @@
> [ -s $_git/merging ] && merging=$(cat $_git/merging | sed 's/^/-p /')
> fi
>
> +# strip ignored files - *1 at a time* - any attempt to stream from 1
> +# while loop to another uses a subprocess and can't pass the variable
> +# back
> +# Also I don't know if this can be put in a shell function
> +for file in ${commitfiles[@]}
> + do
> + commitfiles[$i]=`echo $file | cg-Xignore`
> + ((i++))
> +done
>
> LOGMSG=$(mktemp -t gitci.XXXXXX)
> LOGMSG2=$(mktemp -t gitci.XXXXXX)The variable? What variable?
Show 20 quoted lines
> Index: cg-status
> ===================================================================
> --- d2490ad0bc8b38647c6baff9da3e72c0f25e9f35/cg-status (mode:100755)
> +++ 03662df7d089d4a84987ef9edb50a017b8b42439/cg-status (mode:100755)
> @@ -15,21 +15,11 @@
>
> {
> git-ls-files -z -t --others --deleted --unmerged $EXCLUDE
> -} | sort -z -k 2 | xargs -0 sh -c '
> -while [ "$1" ]; do
> - tag=${1% *};
> - filename=${1#* };
> - case "$filename" in
> - *.[ao] | tags | ,,merge*) ;;
> - *) echo "$tag $filename";;
> - esac
> - shift
> -done
> -' padding
> +} | sort -z -k 2 | cg-Xignore -0 -t | tr "\000" "\n"So you have two ignores now - exclude and Xignore.
-- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor