Re: [PATCH] Stop git-rev-list at sha1 match

From: Petr Baudis <pasky@ucw.cz>
Date: May 11, 2005, 22:17 UTC
Message-ID: <20050511221719.GH22686@pasky.ji.cz>
In-Reply-To: <7vis1pqvi4.fsf@assigned-by-dhcp.cox.net>

Dear diary, on Wed, May 11, 2005 at 11:54:11PM CEST, I got a letter where Junio C Hamano <junkio@cox.net> told me that...

Show 20 quoted lines

> >>>>> "TG" == Thomas Gleixner <tglx@linutronix.de> writes:
> 
> TG> You moved the stop behind the printf which is inconsistent to the other
> TG> stop conditions, but thats a pure cosmetic question as long as it stays
> TG> that way for ever. 
> 
> While I work on the core GIT changes, I often find myself doing
> 
>     $ jit-log -l --since linus
>     $ jit-log -l --since git-jc
> 
> to see what changes I have in my local work repository, and
> seeing the branching point (or origin) at the very end of the
> log made me feel assured that I am not losing anything in the
> log.  But come to think of it, that is really an unnecessary
> thing and stopping _before_ the named commit would make more
> sense.
> 
> Here is a fixed version.  I am CC'ing pasky hoping he would pick
> it up.

Yes, looks better and more consistent with the rest of the stuff.

But the very fact that you want this makes me *quite* nervous - I think this is bad thing to do. The problem is, for something like

     o
     | \
     o  |
     |  o
     |  o
     o /
     o
    ------

it will show the merged revisions properly, but for

     o
     | \
     o  |
    ------
     |  o
     |  o
     o /
     o

it won't show the full merge. Whilst when you do

	*-log --since foo

I think you mean it to show everything going into the tree since foo - that would include the whole branch you cut off now.

Thomas, what are you going to use it for?

> Add --stop-at to git-rev-list command.
> 
> Signed-off-by: Junio C Hamano <junkio@cox.net>

I liked the previous patch revision commit message much better, I have to admit. ;-)

> ---
> --- a/checkout-cache.c
> +++ b/checkout-cache.c

I assume this is irrelevant here?

> --- a/rev-list.c
> +++ b/rev-list.c

Looks ok.

Could you please also update the documentation appropriately? (If we have it, let's keep it up to date.)

> Created: t/t0000.sh (mode:100755)
> --- /dev/null
> +++ b/t/t0000.sh

You want this in too?

Starting to build a testsuite sounds like a good idea, but we should probably first devise some calling convention etc. I personally suck at automated testing.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor