Re: [PATCH] Stop git-rev-list at sha1 match

From: Thomas Gleixner <tglx@linutronix.de>
Date: May 11, 2005, 20:30 UTC
Message-ID: <1115843429.22180.90.camel@tglx>
In-Reply-To: <7vy8alr0mz.fsf@assigned-by-dhcp.cox.net>

On Wed, 2005-05-11 at 13:03 -0700, Junio C Hamano wrote:

> Suggestion.  How about renaming "--to_sha1" to "--since"?  If
> you do not like "--since", then "--stop-at" would also be good.

No preference here :)

Show 7 quoted lines

> Suggestion.  Instead of running sha1_to_hex on the SHA1 of the
> commit and comparing strings for every commit you encounter, how
> about keeping 20-byte raw SHA1 of to_sha1 and doing memcmp of
> 20-byte?  That way you would also detect malformed --to-sha1
> parameter when you do the initial conversion upon argument
> parsing.  Also the argument parsing using get_sha1() would give
> you an added benefit of using mnemonics (tag and heads).

Makes sense. I just used the sha1_to_hex as it is called anyway for the printf

> What do you think about this revision?

You moved the stop behind the printf which is inconsistent to the other stop conditions, but thats a pure cosmetic question as long as it stays that way for ever.

Otherwise not objections.

tglx