Re: Trying to use AUTHOR_DATE

From: Edgar Toernig <froese@gmx.de>
Date: Apr 30, 2005, 13:22 UTC
Message-ID: <20050430152252.0c3fd206.froese@gmx.de>
In-Reply-To: <1114865964.24014.77.camel@localhost.localdomain>

David Woodhouse wrote:

Show 8 quoted lines

>
> On Sat, 2005-04-30 at 14:49 +0200, Edgar Toernig wrote:
> > +       if (tm.tm_sec > 59)
> > +               return;
> 
> During a leap second, won't tm_sec be 60? And in fact you don't seem to
> handle leap seconds at all, so isn't my_mktime going to be out by one
> second for every leap second which has occurred since 1970?

There are no leap-seconds on POSIX systems. They allow tm_sec to be 60 but thats all - 00:00:60 is the same as 00:01:00.

Whether the check should be against 59 or 60? I don't care. It's Linus decision.

> There's a reason I'd rather just let glibc handle it :)

Good joke.

Ciao, ET.