Re: Trying to use AUTHOR_DATE
- From
David Woodhouse <dwmw2@infradead.org>
- Date
- Apr 30, 2005, 12:59 UTC
- Message-ID
- <1114865964.24014.77.camel@localhost.localdomain>
- In-Reply-To
- <20050430144936.6b05cc90.froese@gmx.de>
On Sat, 2005-04-30 at 14:49 +0200, Edgar Toernig wrote:
> + if (tm.tm_sec > 59) > + return;
During a leap second, won't tm_sec be 60? And in fact you don't seem to handle leap seconds at all, so isn't my_mktime going to be out by one second for every leap second which has occurred since 1970?
There's a reason I'd rather just let glibc handle it :)
It's not as if tm_gmtoff is particularly esoteric -- we inherited it from BSD. Let's just use it and let both remaining HPUX users worry about it themselves if they ever want to use git on their systems.
-- dwmw2