Re: Plug memory leak in update-cache.c
- From
Petr Baudis <pasky@ucw.cz>
- Date
- Apr 15, 2005, 23:48 UTC
- Message-ID
- <20050415234807.GS7417@pasky.ji.cz>
- In-Reply-To
- <1113468830.23299.85.camel@nosferatu.lan>
Dear diary, on Thu, Apr 14, 2005 at 10:53:50AM CEST, I got a letter where Martin Schlemmer <azarah@nosferatu.za.org> told me that...
Show 22 quoted lines
> Hi,
>
> Might not be that an big an issue as it should be freed on exit, but
> might cause problems with big trees.
>
> ----
>
> Plug memory leak in update-cache.c.
>
> Signed-off-by: Martin Schlemmer <azarah@nosferatu.za.org>
>
> update-cache.c: 22f3ccd47db4f0888901109a8cbf883d272d1cba
> --- 22f3ccd47db4f0888901109a8cbf883d272d1cba/update-cache.c
> +++ uncommitted/update-cache.c
> @@ -202,6 +202,7 @@
> printf("%s: needs update\n", ce->name);
> continue;
> }
> + free(active_cache[i]);
> active_cache[i] = new;
> }
> }FYI, new could've contained active_cache[i] at that time, so you needed to check for that. Fixed though, thanks for pointing it out.
-- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor