git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[BUG] ls-files showing deleted files (unchecked lstat return value)

From
JRJoe Ranieri <jranieri@grammatech.com>
Date
Feb 17, 2019, 13:49 UTC
Message-ID
<1ff48830-f3de-11f4-9014-c20eb3890c21@grammatech.com>

"git ls-files -m" can show deleted files, despite -d not having been specified. This is due to ls-files.c's show_files function calling lstat but not checking the return value before calling ie_modified with the uninitialized stat structure.

This problem was found using the static analysis tool GrammaTech CodeSonar.
-- 
Thanks and Regards,
Joe Ranieri
Software Engineer
GrammaTech, Inc.
Next: Randall S. Becker
Message 1 of 6 in “[BUG] ls-files showing deleted files (unchecked lstat return value)”
  1. Joe RanieriFeb 17, 2019
  2. Randall S. BeckerFeb 17, 2019
  3. Joe RanieriFeb 18, 2019
  4. SZEDER GáborFeb 18, 2019
  5. Randall S. BeckerFeb 18, 2019
  6. Junio C HamanoFeb 20, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.