RE: [BUG] ls-files showing deleted files (unchecked lstat return value)

From: Randall S. Becker <rsbecker@nexbridge.com>
Date: Feb 18, 2019, 16:14 UTC
Message-ID: <000c01d4c7a5$17915a00$46b40e00$@nexbridge.com>
In-Reply-To: <20190218151725.GL1622@szeder.dev>

On February 18, 2019 10:17, SZEDER Gábor wrote:

Show 11 quoted lines

> To: Joe Ranieri <jranieri@grammatech.com>
> Cc: git@vger.kernel.org
> Subject: Re: [BUG] ls-files showing deleted files (unchecked lstat return
> value)
> 
> On Sun, Feb 17, 2019 at 08:49:39AM -0500, Joe Ranieri wrote:
> > "git ls-files -m" can show deleted files, despite -d not having been
> > specified.
> 
> To my understanding that's intentional: a deleted file is considered modified,
> because its content clearly doesn't match the tracked content.

That's a good point and why I asked for a specific test condition that illustrated the bug as being unanticipated. I'm not sure what Joe supplied elsewhere in the thread does that.

> > This is due to ls-files.c's show_files function calling lstat but not
> > checking the return value before calling ie_modified with the
> > uninitialized stat structure.