Re: [PATCH 08/17] pack-objects: add --path-walk option

From: Derrick Stolee <stolee@gmail.com>
Date: Oct 31, 2024, 02:14 UTC
Message-ID: <1dd36099-1f3f-4078-9009-6c142723430c@gmail.com>
In-Reply-To: <ZyEkWyB/C/lGb36b@nand.local>

On 10/29/24 2:07 PM, Taylor Blau wrote:

> On Mon, Oct 28, 2024 at 12:54:04PM -0700, Jonathan Tan wrote:

Show 8 quoted lines

> Is the thinking there that we care mostly about 'git push' and 'git
> repack' on the client-side?
> 
> I don't think it's unreasonable necessarily, but I would add that
> client-side users definitely do use bitmaps (though not delta islands),
> either when working in a bare repository (where bitmaps are the default)
> or when using 'git gc' (and/or through 'git maintenance') when
> 'repack.writeBitmaps' is enabled.

I suppose some users do use bitmaps, but in my experience, client-side pushes are slower with bitmaps because a typical target branch is faster to compute by doing a commit walk, at least when the bitmaps are older than the new commits in the topic branch. This may be outdated by now, as it has been a few years since I did a client-side test of bitmaps.

Thanks, -Stolee