Re: [PATCH v2 00/17] pack-objects: add --path-walk option for better deltas

From: Derrick Stolee <stolee@gmail.com>
Date: Oct 28, 2024, 17:13 UTC
Message-ID: <00d80855-0530-4384-8d2f-5370ace9c0d5@gmail.com>
In-Reply-To: <Zx/AGrGTN2mQZqGs@nand.local>

On 10/28/24 12:47 PM, Taylor Blau wrote:

Show 9 quoted lines

> On Mon, Oct 28, 2024 at 06:46:07AM +0100, Patrick Steinhardt wrote:
>> I've flagged this internally now at GitLab so that we can provide some
>> more data with some of the repos that are on the bigger side to check
>> whether we can confirm the findings and to prioritize its review.
> 
> I suspect that you'll end up measuring no change assuming that you
> (AFAIK) use bitmaps and (I imagine) delta islands in your production
> configuration? This series is not compatible with either of those
> features to my knowledge.

You are correct that this is not compatible with those features as-is. _Maybe_ there is potential to integrate them in the future, but that would require better understanding of whether the new compression mechanism valuable in enough cases (final storage size or maybe even in repacking time).

At the very least, it would be helpful if some other large repos were tested to see how commonly this could help client-side users. Are there other aspects to a repo's structure that could be important to how effective this approach is?

Thanks, -Stolee