git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] files_read_raw_ref: avoid infinite loop on broken symlinks

From
Johannes Sixt <j6t@kdbg.org>
Date
Oct 6, 2016, 19:31 UTC
Message-ID
<1c39b371-eb41-05d9-3c48-bd41764c9c9a@kdbg.org>
In-Reply-To
<20161006164825.otms5ovz2vzanimw@sigill.intra.peff.net>
Am 06.10.2016 um 18:48 schrieb Jeff King:
> +test_expect_success SYMLINKS 'ref resolution not confused by broken symlinks' '
> +	ln -s does-not-exist .git/broken &&
> +	test_must_fail git rev-parse --verify broken

Hm, lower-case named refs directly in .git are frowned upon, no? If we ever decide to forbid them outright, this ref-parse might still fail, but for the wrong reason. Should you not better pick an example below ref/?

-- Hannes
Previous: Jeff KingNext: Jeff King
Message 5 of 7 in “fix infinite loop in ref resolution”
  1. 0/2 fix infinite loop in ref resolutionJeff King, Oct 6, 2016
  2. 2/2 files_read_raw_ref: prevent infinite retry loops in generalJeff King, Oct 6, 2016
  3. Michael HaggertyOct 10, 2016
  4. 1/2 files_read_raw_ref: avoid infinite loop on broken symlinksJeff King, Oct 6, 2016
  5. Johannes SixtOct 6, 2016
  6. 1/2 files_read_raw_ref: avoid infinite loop on broken symlinksJeff King, Oct 6, 2016
  7. Michael HaggertyOct 10, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.