From: Johannes Sixt <j6t@kdbg.org>
Date: Thu, 06 Oct 2016 19:31:22 GMT
Subject: Re: [PATCH 1/2] files_read_raw_ref: avoid infinite loop on broken symlinks
Message-ID: <1c39b371-eb41-05d9-3c48-bd41764c9c9a@kdbg.org>
In-Reply-To: <20161006164825.otms5ovz2vzanimw@sigill.intra.peff.net>

Am 06.10.2016 um 18:48 schrieb Jeff King:
> +test_expect_success SYMLINKS 'ref resolution not confused by broken symlinks' '
> +	ln -s does-not-exist .git/broken &&
> +	test_must_fail git rev-parse --verify broken

Hm, lower-case named refs directly in .git are frowned upon, no? If we 
ever decide to forbid them outright, this ref-parse might still fail, 
but for the wrong reason. Should you not better pick an example below ref/?

-- Hannes