Re: [PATCH] gitk: Fix "git gui blame" invocation when called from topdir

From: Paul Mackerras <paulus@samba.org>
Date: Nov 14, 2009, 11:14 UTC
Message-ID: <19198.37129.682215.327167@cargo.ozlabs.ibm.com>
In-Reply-To: <1257290501-21093-1-git-send-email-markus.heidelberg@web.de>

Markus Heidelberg writes:

Show 13 quoted lines

> In this case "git rev-parse --git-dir" doesn't return an absolute path,
> but merely ".git", so the selected file has a relative path.
> The function make_relative then tries to make the already relative path
> relative, which results in a path like "../../../../Makefile" with as
> much ".." as the number of parts [pwd] consists of.
> 
> This regression was introduced by commit 9712b81 (gitk: Fix bugs in
> blaming code, 2008-12-06), which fixed "git gui blame" when called from
> subdirs.
> 
> This also fixes it for bare repositories.
> 
> Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>

Thanks, applied.

Paul.