Re: [PATCH resend] gitk: Fix "git gui blame" invocation when called from topdir

From: Paul Mackerras <paulus@samba.org>
Date: Nov 3, 2009, 10:39 UTC
Message-ID: <19184.2163.760155.285153@cargo.ozlabs.ibm.com>
In-Reply-To: <1256990974-32671-1-git-send-email-markus.heidelberg@web.de>

Markus Heidelberg writes:

Show 11 quoted lines

> In this case "git rev-parse --git-dir" doesn't return an absolute path,
> but merely ".git", so the selected file has a relative path.
> The function make_relative then tries to make the already relative path
> relative, which results in a path like "../../../../Makefile" with as
> much ".." as the number of parts [pwd] consists of.
> 
> This regression was introduced by commit 9712b81 (gitk: Fix bugs in
> blaming code, 2008-12-06), which fixed "git gui blame" when called from
> subdirs.
> 
> This also fixes it for bare repositories.

Thanks for the patch, but I'd prefer to just add:

    if {[file pathtype $f] ne "relative"} {
	return $f
    }

at the start of the function. I think that's easier to read than having a big if statement. Would you like to do a new patch or will I just make that change to your patch?

Paul.