Re: [PATCH 2/2] gitk: Markup many strings for translation.

From: Paul Mackerras <paulus@samba.org>
Date: Jul 28, 2007, 06:21 UTC
Message-ID: <18090.57453.466507.354727@cargo.ozlabs.ibm.com>
In-Reply-To: <7vvec5uo01.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano writes:

Show 6 quoted lines

> My preference is 1.b, as the longer term plan (when everybody
> has git 1.5.2 or newer) is to eject git-gui.git project from
> git.git proper, and use the subproject feature to have
> git-gui.git in git.git; it would be good if gitk.git can be
> handled the same way, and the layout 1.b would make it the
> easiest, as it matches how we treat git-gui.git project now.

1.b sounds fine to me too.

> You also expressed in a separate message about "catching package
> require msgcat to avoid breakage".  I think msgcat package is
> part of the standard Tcl distribution since 8.1; how old a
> tcl/tk do you support?

Gitk requires 8.4, so that sounds OK then. I didn't realize it had been part of the standard distribution for so long.

> In any case, I would very much appreciate if any of these will
> *NOT* happen before 1.5.3.  git-gui 0.8.0 which is scheduled to
> be in 1.5.3 will not have i18n.

No problem. :)

By the way, could you do a pull from gitk.git? There are some bug-fixes plus the change to show the index and working directory as separate fake commits, as requested by Linus.

Paul.