Re: [PATCH 2/2] gitk: Markup many strings for translation.

From: Paul Mackerras <paulus@samba.org>
Date: Jul 28, 2007, 02:39 UTC
Message-ID: <18090.44123.905869.974967@cargo.ozlabs.ibm.com>
In-Reply-To: <20070727170300.t01ku4u2sg04sgsk@webmail.tu-harburg.de>

Christian Stimming writes:

Show 6 quoted lines

> Similar to the discussion in git-gui, all user-visible strings are  
> passed through the [mc ...] procedure to have them translated by msgcat.
> 
> Signed-off-by: Christian Stimming <stimming@tuhh.de>
> ---
> @Paul: Are you interested in applying this? If yes, I'd happily

Yes, it doesn't look too bad. The patch seemed to be line-wrapped and whitespace-damaged, though.

Show 5 quoted lines

> provide the Makefile rules for string extraction and translation  
> catalog updates, but I'd like to hear a proposal or decision on where  
> to place them. Should the po files for translation go into the po/  
> subdirectory? And then a proposal/decision of where to install the  
> compiled .msg catalogs will be necessary.

Yes indeed.  Junio?

Is it possible to include the translations, or at least the more common translations, in the Tcl code itself? So far I have managed to have gitk be self-contained, in that it doesn't need any external data files, which simplifies installation and is a useful attribute in some situations.

Also I would want to be sure that gitk wouldn't crash or fail to function if it can't find its message catalogs.

Paul.