Re: Recent issues

From: Paul Mackerras <paulus@samba.org>
Date: Jul 9, 2007, 09:28 UTC
Message-ID: <18065.65446.474822.436800@cargo.ozlabs.ibm.com>
In-Reply-To: <7v7ipcbrfd.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano writes:

Show 8 quoted lines

> * gitk --left-right
> 
>   From: Linus Torvalds <torvalds@linux-foundation.org>
>   Message-ID: <alpine.LFD.0.98.0705051524300.17381@woody.linux-foundation.org>
>   From: Junio C Hamano <junkio@cox.net>
>   Message-ID: <7vabwifl23.fsf@assigned-by-dhcp.cox.net>
> 
> Paulus?

Looks mostly OK; I assume there's no possible downside to using git log -v --pretty=raw rather than git rev-list?

Also, in the second patch, commitside needs to either be indexed by view as well as id, or needs to be "context-switched" by showview. I'll fix it. Since neither you nor Linus included a signed-off-by, I'll combine the patches and fix up a few things.

Show 7 quoted lines

> * gitk tree view fix
> 
>   From: Brian Downing <bdowning@lavos.net>
>   Subject: [PATCH] gitk: Fix for tree view ending in nested directories
>   Message-ID: <20070704212643.GR4087@lavos.net>
> 
> Paulus?

Looks reasonable.

Paul.