git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix gitk this->selected diffs

From
Paul Mackerras <paulus@samba.org>
Date
Nov 28, 2005, 08:28 UTC
Message-ID
<17290.49053.798223.402920@cargo.ozlabs.ibm.com>
In-Reply-To
<20051127222929.GM3393@nowhere.earth>
Yann Dirson writes:
> This patch changes the two git-diff-tree calls to get the necessary
> two ids in this case.  It does so by propagating a "singlecommit" flag
> through all functions involved via an additional argument.

Seems a bit ugly... Why can't we just make the ids list that we pass around have either 1 or 2 elements instead? I'll have a closer look, but assuming that works I think it'll be a lot cleaner.

Thanks, Paul.

Previous: Yann Dirson
Message 2 of 2 in “Fix gitk this->selected diffs”
  1. Fix gitk this->selected diffsYann Dirson, Nov 27, 2005
  2. Paul MackerrasNov 28, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.