From: Paul Mackerras Date: Mon, 28 Nov 2005 08:28:13 GMT Subject: Re: [PATCH] Fix gitk this->selected diffs Message-ID: <17290.49053.798223.402920@cargo.ozlabs.ibm.com> In-Reply-To: <20051127222929.GM3393@nowhere.earth> Yann Dirson writes: > This patch changes the two git-diff-tree calls to get the necessary > two ids in this case. It does so by propagating a "singlecommit" flag > through all functions involved via an additional argument. Seems a bit ugly... Why can't we just make the ids list that we pass around have either 1 or 2 elements instead? I'll have a closer look, but assuming that works I think it'll be a lot cleaner. Thanks, Paul.