Re: Joining cg-*-id

From: Paul Mackerras <paulus@samba.org>
Date: Sep 21, 2005, 10:35 UTC
Message-ID: <17201.14169.150101.991868@cargo.ozlabs.ibm.com>
In-Reply-To: <Pine.LNX.4.58.0509201224360.2553@g5.osdl.org>

Linus Torvalds writes:

Show 9 quoted lines

> On Tue, 20 Sep 2005, Linus Torvalds wrote:
> > 
> > (Side note: the "gitk" thing works really badly. gitk doesn't quote its 
> > arguments to "git-rev-list", so something like
> > 
> > 	gitk --since="1 month ago"
> > 
> > does NOT work, while "--since=yesterday" does, because it has no spaces. 
> > Gaah. "Obi-Paul Mackerras, you're our only hope")

<scratches head> It works for me - with your rev-list.c and rev-parse.c patches, an unmodified gitk (as in current git.git) works just fine; both gitk --since=yesterday and gitk --since="1 day ago" give the same set of commits (two merges and an NTFS change, plus "Linux v2.6.14-rc2" and a SCSI zfcp patch shown with open circles).

> There is 'eval' magic with pure lists. I'm getting convinced that tcl is 
> evil after all - that's just _confusing_. A real language shouldn't have 
> semantic differences from this change, but it clearly does.

I can't see any semantic difference...

Can you still replicate the problem with an unmodified gitk?

Paul.