Re: [PATCH] Teach git-rev-list --simplify-forks

From: Derrick Stolee <stolee@gmail.com>
Date: Apr 28, 2020, 14:11 UTC
Message-ID: <155e3be2-1852-3590-2cd9-c868fa5a696a@gmail.com>
In-Reply-To: <070c07f6-5b36-89e7-a9fe-9bd321fcb97e@gmail.com>

On 4/28/2020 8:49 AM, Antonio Russo wrote:

Show 12 quoted lines

> On 4/27/20 4:55 AM, Derrick Stolee wrote:
>>
>> This is probably because the tests run a second round with GIT_TEST_COMMIT_GRAPH=1, which enables the commit-graph feature. This triggers a different set of logic for the topo-order, which ignores the logic the way you inserted it here.
>>
> 
> Thank you for pointing me at this.  If I now understand correctly, the commit information
> is not yet necessarily loaded for all commits at this point, and therefore the logic here
> will need to be called later on (and makes it more complicated).
> 
> Am I correct that this loading of parents happens during traverse_commit_list_filtered
> (for the case of rev-list)?  Also, am I correct that there are not yet any hooks to
> filter out edges (of the graph of commits)?

I mean that if you have a commit-graph, then a completely disjoint set of code is run instead of the code you modified. See [1] for the blocks of code that are run instead.

[1] https://github.com/git/git/commit/b45424181e9e8b2284a48c6db7b8db635bbfccc8

Thanks, -Stolee