Re: [PATCH] Teach git-rev-list --simplify-forks

From: Antonio Russo <antonio.e.russo@gmail.com>
Date: Apr 28, 2020, 12:49 UTC
Message-ID: <070c07f6-5b36-89e7-a9fe-9bd321fcb97e@gmail.com>
In-Reply-To: <4ee983f6-402f-85bb-25a8-75b39f07cabb@gmail.com>

On 4/27/20 4:55 AM, Derrick Stolee wrote:

> 
> This is probably because the tests run a second round with GIT_TEST_COMMIT_GRAPH=1, which enables the commit-graph feature. This triggers a different set of logic for the topo-order, which ignores the logic the way you inserted it here.
>

Thank you for pointing me at this. If I now understand correctly, the commit information is not yet necessarily loaded for all commits at this point, and therefore the logic here will need to be called later on (and makes it more complicated).

Am I correct that this loading of parents happens during traverse_commit_list_filtered (for the case of rev-list)? Also, am I correct that there are not yet any hooks to filter out edges (of the graph of commits)?

Thank you, Antonio