Re: [PATCH] format-patch: introduce format.outputDirectory configuration

From: Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>
Date: Jun 19, 2015, 11:34 UTC
Message-ID: <1537731273.629800.1434713654223.JavaMail.zimbra@ensimag.grenoble-inp.fr>
In-Reply-To: <1434626280-4610-1-git-send-email-kuleshovmail@gmail.com>

Alexander Kuleshov <kuleshovmail@gmail.com> writes:

Show 8 quoted lines

> +test_expect_success "format-patch format.outputDirectory option" '
> + git config format.outputDirectory "patches/" &&
> + git format-patch master..side &&
> + cnt=$(ls | wc -l) &&
> + echo $cnt &&
> + test $cnt = 3 &&
> + git config --unset format.outputDirectory
> +'

You should probably do:

> + test_config format.outputDirectory "patches/" &&

instead of:

> + git config format.outputDirectory "patches/" &&
> [...]
> + git config --unset format.outputDirectory

This way there shouldn't be any problem with the tests following yours if your test fails in the middle.

Rémi