Re: [PATCH] fetch: print an error when declining to request an unadvertised object

From: Matt McCutchen <matt@mattmccutchen.net>
Date: Feb 22, 2017, 16:17 UTC
Message-ID: <1487780254.3016.1.camel@mattmccutchen.net>
In-Reply-To: <xmqqvas4gie9.fsf@gitster.mtv.corp.google.com>

On Mon, 2017-02-20 at 22:36 -0800, Junio C Hamano wrote:

Show 10 quoted lines

> Hmph, I would have expected this to be done as a three-patch series,
> 
>  * move the loop at the end of cmd_fetch_pack() to a separate helper
>    function report_unmatched_refs() and call it;
> 
>  * add a call to report_unmatched_refs() to the transport layer;
> 
>  * enhance report_unmatched_refs() by introducing match_status
>    field and adding new code to filter_refs() to diagnose other
>    kinds of errors.

Sure.

> The result looks reasonable from a cursory read, though.
> 
> Thanks for following it up to the completion.

This remark led me to believe you were satisfied with the single patch, but the last "What's cooking in git.git" mail says "Expecting a split series?".

Anyway, I made a split series and will send it in a moment. I don't know if all the commit messages include exactly the information you want; hopefully you're happy to edit them as desired. Compared to the previous patch, there is one fix in the net result: fixing t5500-fetch- pack.sh to deal with the internationalized "no such remote ref" message.

Matt