git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rev-list: use hdr_termination instead of a always using a newline

From
Dennis Kaarsemaker <dennis@kaarsemaker.net>
Date
Oct 20, 2016, 18:49 UTC
Message-ID
<1476989380.28685.8.camel@kaarsemaker.net>
In-Reply-To
<20161020181930.21084-1-jacob.e.keller@intel.com>
On Thu, 2016-10-20 at 11:19 -0700, Jacob Keller wrote:
Show 7 quoted lines
> Here's my solution, with an updated test using a helper function based
> on using sed (which I think is more portable than tail -n1 ?). The
> change actually is very simple. I ran the test suite and it appears to
> be not breaking anyone else since the normal case is
> hdr_termination="\n" except in the cases where it needs to be NUL.
> 
> Thanks for the bug report!

I like both improvements, and both 'make test' and gitweb are happy with this version. Thanks for the quick fix.

D.
Previous: Jacob KellerNext: Junio C Hamano
Message 2 of 4 in “rev-list: use hdr_termination instead of a always using a newline”
  1. rev-list: use hdr_termination instead of a always using a newlineJacob Keller, Oct 20, 2016
  2. Dennis KaarsemakerOct 20, 2016
  3. Junio C HamanoOct 20, 2016
  4. Jacob KellerOct 20, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.