From: Dennis Kaarsemaker <dennis@kaarsemaker.net>
Date: Thu, 20 Oct 2016 18:49:40 GMT
Subject: Re: [PATCH] rev-list: use hdr_termination instead of a always using a newline
Message-ID: <1476989380.28685.8.camel@kaarsemaker.net>
In-Reply-To: <20161020181930.21084-1-jacob.e.keller@intel.com>

On Thu, 2016-10-20 at 11:19 -0700, Jacob Keller wrote:
> Here's my solution, with an updated test using a helper function based
> on using sed (which I think is more portable than tail -n1 ?). The
> change actually is very simple. I ran the test suite and it appears to
> be not breaking anyone else since the normal case is
> hdr_termination="\n" except in the cases where it needs to be NUL.
> 
> Thanks for the bug report!

I like both improvements, and both 'make test' and gitweb are happy
with this version. Thanks for the quick fix.

D.