Re: [WIP PATCH 00/14] Protocol v2 patches

From: David Turner <dturner@twopensource.com>
Date: May 2, 2016, 20:41 UTC
Message-ID: <1462221687.4123.79.camel@twopensource.com>
In-Reply-To: <1461972887-22100-1-git-send-email-sbeller@google.com>

On Fri, 2016-04-29 at 16:34 -0700, Stefan Beller wrote:

Show 18 quoted lines

> Hi David,
> 
> here are my patches for a protocol v2.
> 
> ("Negotiate capabilities before doing anything else", or as code:
> 
>         static void upload_pack_version_2(void)
>         {
>                 send_capabilities_version_2();
>                 receive_capabilities_version_2();
> 
>                 /* The rest of the protocol stays the same,
> capabilities advertising
>                    is disabled though. */
>                 advertise_capabilities = 0;
>                 upload_pack();
>         }
> )

Overall, except for the comments I made, these patches seem sensible.

Would it be possible to add some docs on the new protocol when you re -roll? (I know these are just the initial patches, but it really helps me to see an explanation along with the code).