Re: [PATCH 08/14] fetch-pack: factor out get_selected_capabilities_list
- From
David Turner <dturner@twopensource.com>
- Date
- May 2, 2016, 19:09 UTC
- Message-ID
- <1462216172.4123.71.camel@twopensource.com>
- In-Reply-To
- <1461972887-22100-9-git-send-email-sbeller@google.com>
On Fri, 2016-04-29 at 16:34 -0700, Stefan Beller wrote:
Show 7 quoted lines
> + struct string_list_item *item;
> + get_selected_capabilities_list(&list, args);
> + for_each_string_list_item(item, &list) {
> + strbuf_addstr(&c, " ");
> + strbuf_addstr(&c, item->string);
> + }
> +I think the contents of list leak here -- you need a string_list_clear.