git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v6 07/19] index-helper: add --detach

From
David Turner <dturner@twopensource.com>
Date
Apr 27, 2016, 20:04 UTC
Message-ID
<1461787481-877-8-git-send-email-dturner@twopensource.com>
In-Reply-To
<1461787481-877-1-git-send-email-dturner@twopensource.com>
From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>

We detach after creating and opening the socket, because otherwise we might return control to the shell before index-helper is ready to accept commands. This might lead to flaky tests.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: David Turner <dturner@twopensource.com>
---
 Documentation/git-index-helper.txt |  3 +++
 index-helper.c                     | 15 +++++++++++++--
 2 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/Documentation/git-index-helper.txt b/Documentation/git-index-helper.txt
index 4eb3d95..18e1636 100644
--- a/Documentation/git-index-helper.txt
+++ b/Documentation/git-index-helper.txt
@@ -31,6 +31,9 @@ OPTIONS
 	for reading an index, but because it will happen in the
 	background, it's not noticable. `--strict` is enabled by default.
 
+--detach::
+	Detach from the shell.
+
 NOTES
 -----
 
diff --git a/index-helper.c b/index-helper.c
index 7400d68..4273773 100644
--- a/index-helper.c
+++ b/index-helper.c
@@ -17,7 +17,7 @@ struct shm {
 
 static struct shm shm_index;
 static struct shm shm_base_index;
-static int to_verify = 1;
+static int daemonized, to_verify = 1;
 
 static void log_warning(const char *warning, ...)
 {
@@ -59,6 +59,8 @@ static void cleanup_shm(void)
 
 static void cleanup(void)
 {
+	if (daemonized)
+		return;
 	unlink(git_path("index-helper.sock"));
 	cleanup_shm();
 }
@@ -318,7 +320,7 @@ static const char * const usage_text[] = {
 int main(int argc, char **argv)
 {
 	const char *prefix;
-	int idle_in_seconds = 600;
+	int idle_in_seconds = 600, detach = 0;
 	int fd;
 	struct strbuf socket_path = STRBUF_INIT;
 	struct option options[] = {
@@ -326,6 +328,7 @@ int main(int argc, char **argv)
 			    N_("exit if not used after some seconds")),
 		OPT_BOOL(0, "strict", &to_verify,
 			 "verify shared memory after creating"),
+		OPT_BOOL(0, "detach", &detach, "detach the process"),
 		OPT_END()
 	};
 
@@ -349,6 +352,14 @@ int main(int argc, char **argv)
 	if (fd < 0)
 		die_errno(_("could not set up index-helper socket"));
 
+	if (!freopen("/dev/null", "w", stderr))
+		die_errno("failed to redirect stderr to /dev/null");
+
+	if (!freopen("/dev/null", "w", stdout))
+		die_errno("failed to redirect stdout to /dev/null");
+
+	if (detach && daemonize(&daemonized))
+		die_errno(_("unable to detach"));
 	loop(fd, idle_in_seconds);
 
 	close(fd);
-- 
2.4.2.767.g62658d5-twtrsrc
Previous: David TurnerNext: David Turner
Message 12 of 24 in “index-helper/watchman”
  1. 00/19 index-helper/watchmanDavid Turner, Apr 27, 2016
  2. 01/19 read-cache.c: fix constness of verify_hdr()David Turner, Apr 27, 2016
  3. 02/19 read-cache: allow to keep mmap'd memory after readingDavid Turner, Apr 27, 2016
  4. 03/19 index-helper: new daemon for caching index and related stuffDavid Turner, Apr 27, 2016
  5. Junio C HamanoApr 28, 2016
  6. David TurnerApr 29, 2016
  7. Junio C HamanoApr 29, 2016
  8. Duy NguyenMay 1, 2016
  9. 04/19 index-helper: add --strictDavid Turner, Apr 27, 2016
  10. 05/19 index-helper: log warningsDavid Turner, Apr 27, 2016
  11. 06/19 daemonize(): set a flag before exiting the main processDavid Turner, Apr 27, 2016
  12. 07/19 index-helper: add --detachDavid Turner, Apr 27, 2016
  13. 08/19 read-cache: add watchman 'WAMA' extensionDavid Turner, Apr 27, 2016
  14. 09/19 Add watchman support to reduce index refresh costDavid Turner, Apr 27, 2016
  15. 10/19 index-helper: use watchman to avoid refreshing index with lstat()David Turner, Apr 27, 2016
  16. 11/19 update-index: enable/disable watchman supportDavid Turner, Apr 27, 2016
  17. 12/19 unpack-trees: preserve index extensionsDavid Turner, Apr 27, 2016
  18. 13/19 watchman: add a config option to enable the extensionDavid Turner, Apr 27, 2016
  19. 14/19 index-helper: kill modeDavid Turner, Apr 27, 2016
  20. 15/19 index-helper: don't run if already runningDavid Turner, Apr 27, 2016
  21. 16/19 index-helper: autorun modeDavid Turner, Apr 27, 2016
  22. 17/19 index-helper: optionally automatically runDavid Turner, Apr 27, 2016
  23. 18/19 Add tracing to measure where most of the time is spentDavid Turner, Apr 27, 2016
  24. 19/19 untracked-cache: config optionDavid Turner, Apr 27, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.