git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v6 15/19] index-helper: don't run if already running

From
David Turner <dturner@twopensource.com>
Date
Apr 27, 2016, 20:04 UTC
Message-ID
<1461787481-877-16-git-send-email-dturner@twopensource.com>
In-Reply-To
<1461787481-877-1-git-send-email-dturner@twopensource.com>
Signed-off-by: David Turner <dturner@twopensource.com>
---
 index-helper.c          | 7 +++++++
 t/t7900-index-helper.sh | 9 +++++++++
 2 files changed, 16 insertions(+)
diff --git a/index-helper.c b/index-helper.c
index 60a71f2..092c814 100644
--- a/index-helper.c
+++ b/index-helper.c
@@ -463,6 +463,13 @@ int main(int argc, char **argv)
 		return 0;
 	}
 
+	/* check that no other copy is running */
+	fd = unix_stream_connect(git_path("index-helper.sock"));
+	if (fd > 0)
+		die(_("Already running"));
+	if (errno != ECONNREFUSED && errno != ENOENT)
+		die_errno(_("Unexpected error checking socket"));
+
 	atexit(cleanup);
 	sigchain_push_common(cleanup_on_signal);
 
diff --git a/t/t7900-index-helper.sh b/t/t7900-index-helper.sh
index e71b5af..7159971 100755
--- a/t/t7900-index-helper.sh
+++ b/t/t7900-index-helper.sh
@@ -29,4 +29,13 @@ test_expect_success 'index-helper creates usable path file and can be killed' '
 	test_path_is_missing .git/index-helper.sock
 '
 
+test_expect_success 'index-helper will not start if already running' '
+	test_when_finished "git index-helper --kill" &&
+	git index-helper --detach &&
+	test -S .git/index-helper.sock &&
+	test_must_fail git index-helper 2>err &&
+	test -S .git/index-helper.sock &&
+	grep "Already running" err
+'
+
 test_done
-- 
2.4.2.767.g62658d5-twtrsrc
Previous: David TurnerNext: David Turner
Message 20 of 24 in “index-helper/watchman”
  1. 00/19 index-helper/watchmanDavid Turner, Apr 27, 2016
  2. 01/19 read-cache.c: fix constness of verify_hdr()David Turner, Apr 27, 2016
  3. 02/19 read-cache: allow to keep mmap'd memory after readingDavid Turner, Apr 27, 2016
  4. 03/19 index-helper: new daemon for caching index and related stuffDavid Turner, Apr 27, 2016
  5. Junio C HamanoApr 28, 2016
  6. David TurnerApr 29, 2016
  7. Junio C HamanoApr 29, 2016
  8. Duy NguyenMay 1, 2016
  9. 04/19 index-helper: add --strictDavid Turner, Apr 27, 2016
  10. 05/19 index-helper: log warningsDavid Turner, Apr 27, 2016
  11. 06/19 daemonize(): set a flag before exiting the main processDavid Turner, Apr 27, 2016
  12. 07/19 index-helper: add --detachDavid Turner, Apr 27, 2016
  13. 08/19 read-cache: add watchman 'WAMA' extensionDavid Turner, Apr 27, 2016
  14. 09/19 Add watchman support to reduce index refresh costDavid Turner, Apr 27, 2016
  15. 10/19 index-helper: use watchman to avoid refreshing index with lstat()David Turner, Apr 27, 2016
  16. 11/19 update-index: enable/disable watchman supportDavid Turner, Apr 27, 2016
  17. 12/19 unpack-trees: preserve index extensionsDavid Turner, Apr 27, 2016
  18. 13/19 watchman: add a config option to enable the extensionDavid Turner, Apr 27, 2016
  19. 14/19 index-helper: kill modeDavid Turner, Apr 27, 2016
  20. 15/19 index-helper: don't run if already runningDavid Turner, Apr 27, 2016
  21. 16/19 index-helper: autorun modeDavid Turner, Apr 27, 2016
  22. 17/19 index-helper: optionally automatically runDavid Turner, Apr 27, 2016
  23. 18/19 Add tracing to measure where most of the time is spentDavid Turner, Apr 27, 2016
  24. 19/19 untracked-cache: config optionDavid Turner, Apr 27, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.