git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv2 3/5] submodule--helper clone: remove double path checking

From
Stefan Beller <sbeller@google.com>
Date
Mar 31, 2016, 21:04 UTC
Message-ID
<1459458280-17619-4-git-send-email-sbeller@google.com>
In-Reply-To
<1459458280-17619-1-git-send-email-sbeller@google.com>

We make sure that the parent directory of path exists (or create it otherwise) and then do the same for path + "/.git".

That is equivalent to just making sure that the parent directory of path + "/.git" exists (or create it otherwise).

Signed-off-by: Stefan Beller <sbeller@google.com>
---
 builtin/submodule--helper.c | 4 ----
 1 file changed, 4 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 4f0b002..0b9f546 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -215,11 +215,7 @@ static int module_clone(int argc, const char **argv, const char *prefix)
 	}
 
 	/* Write a .git file in the submodule to redirect to the superproject. */
-	if (safe_create_leading_directories_const(path) < 0)
-		die(_("could not create directory '%s'"), path);
-
 	strbuf_addf(&sb, "%s/.git", path);
-
 	if (safe_create_leading_directories_const(sb.buf) < 0)
 		die(_("could not create leading directories of '%s'"), sb.buf);
 	submodule_dot_git = fopen(sb.buf, "w");
-- 
2.5.0.264.g39f00fe
Previous: Eric SunshineNext: Eric Sunshine
Message 5 of 12 in “[PATCHv2 0/5] Fix relative path issues in recursive submodules.”
  1. Stefan BellerMar 31, 2016
  2. 1/5 recursive submodules: test for relative pathsStefan Beller, Mar 31, 2016
  3. 2/5 submodule--helper clone: simplify path checkStefan Beller, Mar 31, 2016
  4. Eric SunshineMar 31, 2016
  5. 3/5 submodule--helper clone: remove double path checkingStefan Beller, Mar 31, 2016
  6. Eric SunshineMar 31, 2016
  7. Junio C HamanoMar 31, 2016
  8. 4/5 submodule--helper, module_clone: always operate on absolute pathsStefan Beller, Mar 31, 2016
  9. Junio C HamanoMar 31, 2016
  10. Stefan BellerMar 31, 2016
  11. Stefan BellerMar 31, 2016
  12. 5/5 submodule--helper, module_clone: catch fprintf failureStefan Beller, Mar 31, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.