From: Stefan Beller Date: Thu, 31 Mar 2016 21:04:38 GMT Subject: [PATCHv2 3/5] submodule--helper clone: remove double path checking Message-ID: <1459458280-17619-4-git-send-email-sbeller@google.com> In-Reply-To: <1459458280-17619-1-git-send-email-sbeller@google.com> We make sure that the parent directory of path exists (or create it otherwise) and then do the same for path + "/.git". That is equivalent to just making sure that the parent directory of path + "/.git" exists (or create it otherwise). Signed-off-by: Stefan Beller --- builtin/submodule--helper.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index 4f0b002..0b9f546 100644 --- a/builtin/submodule--helper.c +++ b/builtin/submodule--helper.c @@ -215,11 +215,7 @@ static int module_clone(int argc, const char **argv, const char *prefix) } /* Write a .git file in the submodule to redirect to the superproject. */ - if (safe_create_leading_directories_const(path) < 0) - die(_("could not create directory '%s'"), path); - strbuf_addf(&sb, "%s/.git", path); - if (safe_create_leading_directories_const(sb.buf) < 0) die(_("could not create leading directories of '%s'"), sb.buf); submodule_dot_git = fopen(sb.buf, "w"); -- 2.5.0.264.g39f00fe