git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv21 08/10] submodule helper: remove double 'fatal: ' prefix

From
Stefan Beller <sbeller@google.com>
Date
Mar 1, 2016, 02:07 UTC
Message-ID
<1456798040-30129-9-git-send-email-sbeller@google.com>
In-Reply-To
<1456798040-30129-1-git-send-email-sbeller@google.com>
The prefix is added by die(...), so we don't have to do it.
Signed-off-by: Stefan Beller <sbeller@google.com>
---
 builtin/submodule--helper.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index fd2b168..9e8109e 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -516,13 +516,13 @@ int cmd_submodule__helper(int argc, const char **argv, const char *prefix)
 {
 	int i;
 	if (argc < 2)
-		die(_("fatal: submodule--helper subcommand must be "
+		die(_("submodule--helper subcommand must be "
 		      "called with a subcommand"));
 
 	for (i = 0; i < ARRAY_SIZE(commands); i++)
 		if (!strcmp(argv[1], commands[i].cmd))
 			return commands[i].fn(argc - 1, argv + 1, prefix);
 
-	die(_("fatal: '%s' is not a valid submodule--helper "
+	die(_("'%s' is not a valid submodule--helper "
 	      "subcommand"), argv[1]);
 }
-- 
2.8.0.rc0.1.g68b4e3f
Previous: Stefan BellerNext: Stefan Beller
Message 9 of 12 in “[PATCHv21 00/10] Expose submodule parallelism to the user”
  1. Stefan BellerMar 1, 2016
  2. 01/10 submodule-config: keep update strategy aroundStefan Beller, Mar 1, 2016
  3. 02/10 submodule-config: drop check against NULLStefan Beller, Mar 1, 2016
  4. 03/10 fetching submodules: respect `submodule.fetchJobs` config optionStefan Beller, Mar 1, 2016
  5. 04/10 submodule update: direct error message to stderrStefan Beller, Mar 1, 2016
  6. 05/10 run_processes_parallel: treat output of children as byte arrayStefan Beller, Mar 1, 2016
  7. 06/10 run_processes_parallel: rename parameters for the callbacksStefan Beller, Mar 1, 2016
  8. 07/10 git submodule update: have a dedicated helper for cloningStefan Beller, Mar 1, 2016
  9. 08/10 submodule helper: remove double 'fatal: ' prefixStefan Beller, Mar 1, 2016
  10. 09/10 submodule update: expose parallelism to the userStefan Beller, Mar 1, 2016
  11. 10/10 clone: allow an explicit argument for parallel submodule clonesStefan Beller, Mar 1, 2016
  12. Junio C HamanoMar 1, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.