git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv21 04/10] submodule update: direct error message to stderr

From
Stefan Beller <sbeller@google.com>
Date
Mar 1, 2016, 02:07 UTC
Message-ID
<1456798040-30129-5-git-send-email-sbeller@google.com>
In-Reply-To
<1456798040-30129-1-git-send-email-sbeller@google.com>

Reroute the error message for specified but initialized submodules to stderr instead of stdout.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Stefan Beller <sbeller@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 git-submodule.sh           | 4 ++--
 t/t7400-submodule-basic.sh | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index 9bc5c5f..9ee86d4 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -693,7 +693,7 @@ cmd_update()
 
 		if test "$update_module" = "none"
 		then
-			echo "Skipping submodule '$displaypath'"
+			echo >&2 "Skipping submodule '$displaypath'"
 			continue
 		fi
 
@@ -702,7 +702,7 @@ cmd_update()
 			# Only mention uninitialized submodules when its
 			# path have been specified
 			test "$#" != "0" &&
-			say "$(eval_gettext "Submodule path '\$displaypath' not initialized
+			say >&2 "$(eval_gettext "Submodule path '\$displaypath' not initialized
 Maybe you want to use 'update --init'?")"
 			continue
 		fi
diff --git a/t/t7400-submodule-basic.sh b/t/t7400-submodule-basic.sh
index 540771c..5991e3c 100755
--- a/t/t7400-submodule-basic.sh
+++ b/t/t7400-submodule-basic.sh
@@ -462,7 +462,7 @@ test_expect_success 'update --init' '
 	git config --remove-section submodule.example &&
 	test_must_fail git config submodule.example.url &&
 
-	git submodule update init > update.out &&
+	git submodule update init 2> update.out &&
 	cat update.out &&
 	test_i18ngrep "not initialized" update.out &&
 	test_must_fail git rev-parse --resolve-git-dir init/.git &&
@@ -480,7 +480,7 @@ test_expect_success 'update --init from subdirectory' '
 	mkdir -p sub &&
 	(
 		cd sub &&
-		git submodule update ../init >update.out &&
+		git submodule update ../init 2>update.out &&
 		cat update.out &&
 		test_i18ngrep "not initialized" update.out &&
 		test_must_fail git rev-parse --resolve-git-dir ../init/.git &&
-- 
2.8.0.rc0.1.g68b4e3f
Previous: Stefan BellerNext: Stefan Beller
Message 5 of 12 in “[PATCHv21 00/10] Expose submodule parallelism to the user”
  1. Stefan BellerMar 1, 2016
  2. 01/10 submodule-config: keep update strategy aroundStefan Beller, Mar 1, 2016
  3. 02/10 submodule-config: drop check against NULLStefan Beller, Mar 1, 2016
  4. 03/10 fetching submodules: respect `submodule.fetchJobs` config optionStefan Beller, Mar 1, 2016
  5. 04/10 submodule update: direct error message to stderrStefan Beller, Mar 1, 2016
  6. 05/10 run_processes_parallel: treat output of children as byte arrayStefan Beller, Mar 1, 2016
  7. 06/10 run_processes_parallel: rename parameters for the callbacksStefan Beller, Mar 1, 2016
  8. 07/10 git submodule update: have a dedicated helper for cloningStefan Beller, Mar 1, 2016
  9. 08/10 submodule helper: remove double 'fatal: ' prefixStefan Beller, Mar 1, 2016
  10. 09/10 submodule update: expose parallelism to the userStefan Beller, Mar 1, 2016
  11. 10/10 clone: allow an explicit argument for parallel submodule clonesStefan Beller, Mar 1, 2016
  12. Junio C HamanoMar 1, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.