git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv12 0/7] Expose submodule parallelism to the user

From
Stefan Beller <sbeller@google.com>
Date
Feb 18, 2016, 22:19 UTC
Message-ID
<1455833964-3629-1-git-send-email-sbeller@google.com>
Thanks Junio for a review of v11!

I addressed the memory issue with the interdiff (in patch 1/7) as follows: Interdiff to v11:

diff --git a/submodule.c b/submodule.c
index 263cb2a..45d0967 100644
--- a/submodule.c
+++ b/submodule.c
@@ -219,6 +219,9 @@ void gitmodules_config(void)
 int parse_submodule_update_strategy(const char *value,
                struct submodule_update_strategy *dst)
 {
+       const char *com;
+
+       free((void*)dst->command);
        dst->command = NULL;
        if (!strcmp(value, "none"))
                dst->type = SM_UPDATE_NONE;
@@ -228,9 +231,10 @@ int parse_submodule_update_strategy(const char *value,
                dst->type = SM_UPDATE_REBASE;
        else if (!strcmp(value, "merge"))
                dst->type = SM_UPDATE_MERGE;
-       else if (skip_prefix(value, "!", &dst->command))
+       else if (skip_prefix(value, "!", &com)) {
                dst->type = SM_UPDATE_COMMAND;
-       else
+               dst->command = xstrdup(com);
+       } else
                return -1;
        return 0;
 }

Stefan Beller (7):
  submodule-config: keep update strategy around
  submodule-config: drop check against NULL
  fetching submodules: respect `submodule.fetchJobs` config option
  submodule update: direct error message to stderr
  git submodule update: have a dedicated helper for cloning
  submodule update: expose parallelism to the user
  clone: allow an explicit argument for parallel submodule clones

 Documentation/config.txt        |   6 +
 Documentation/git-clone.txt     |   6 +-
 Documentation/git-submodule.txt |   7 +-
 builtin/clone.c                 |  19 +++-
 builtin/fetch.c                 |   2 +-
 builtin/submodule--helper.c     | 239 ++++++++++++++++++++++++++++++++++++++++
 git-submodule.sh                |  54 ++++-----
 submodule-config.c              |  18 ++-
 submodule-config.h              |   2 +
 submodule.c                     |  39 ++++++-
 submodule.h                     |  18 +++
 t/t5526-fetch-submodules.sh     |  14 +++
 t/t7400-submodule-basic.sh      |   4 +-
 t/t7406-submodule-update.sh     |  27 +++++
 14 files changed, 406 insertions(+), 49 deletions(-)
-- 
2.7.0.rc0.34.g65aed89
Next: Stefan Beller
Message 1 of 14 in “[PATCHv12 0/7] Expose submodule parallelism to the user”
  1. Stefan BellerFeb 18, 2016
  2. 1/7 submodule-config: keep update strategy aroundStefan Beller, Feb 18, 2016
  3. 2/7 submodule-config: drop check against NULLStefan Beller, Feb 18, 2016
  4. 3/7 fetching submodules: respect `submodule.fetchJobs` config optionStefan Beller, Feb 18, 2016
  5. 4/7 submodule update: direct error message to stderrStefan Beller, Feb 18, 2016
  6. 5/7 git submodule update: have a dedicated helper for cloningStefan Beller, Feb 18, 2016
  7. 6/7 submodule update: expose parallelism to the userStefan Beller, Feb 18, 2016
  8. 7/7 clone: allow an explicit argument for parallel submodule clonesStefan Beller, Feb 18, 2016
  9. Junio C HamanoFeb 18, 2016
  10. Stefan BellerFeb 18, 2016
  11. Stefan BellerFeb 18, 2016
  12. Junio C HamanoFeb 18, 2016
  13. Stefan BellerFeb 18, 2016
  14. Junio C HamanoFeb 19, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.