git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv2 2/3] git-p4: support multiple depot paths in p4 submit

From
Luke Diamand <luke@diamand.org>
Date
Dec 19, 2015, 09:39 UTC
Message-ID
<1450517980-1744-3-git-send-email-luke@diamand.org>
In-Reply-To
<1450517980-1744-1-git-send-email-luke@diamand.org>
From: Sam Hocevar <sam@hocevar.net>

When submitting from a repository that was cloned using a client spec, use the full list of paths when ruling out files that are outside the view. This fixes a bug where only files pertaining to the first path would be included in the p4 submit.

Signed-off-by: Sam Hocevar <sam@hocevar.net>
Signed-off-by: Luke Diamand <luke@diamand.org>
---
 git-p4.py | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/git-p4.py b/git-p4.py
index 7a9dd6a..122aff2 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -1458,6 +1458,8 @@ class P4Submit(Command, P4UserMap):
            Remove lines in the Files section that show changes to files
            outside the depot path we're committing into."""
 
+        [upstream, settings] = findUpstreamBranchPoint()
+
         template = ""
         inFilesSection = False
         for line in p4_read_pipe_lines(['change', '-o']):
@@ -1470,8 +1472,13 @@ class P4Submit(Command, P4UserMap):
                     lastTab = path.rfind("\t")
                     if lastTab != -1:
                         path = path[:lastTab]
-                        if not p4PathStartsWith(path, self.depotPath):
-                            continue
+                        if settings.has_key('depot-paths'):
+                            if not [p for p in settings['depot-paths']
+                                    if p4PathStartsWith(path, p)]:
+                                continue
+                        else:
+                            if not p4PathStartsWith(path, self.depotPath):
+                                continue
                 else:
                     inFilesSection = False
             else:
-- 
2.6.2.474.g3eb3291
Previous: Luke DiamandNext: Luke Diamand
Message 3 of 5 in “[PATCHv2 0/3] git-p4: fixing p4ChangesForPaths”
  1. Luke DiamandDec 19, 2015
  2. 1/3 git-p4: failing test case for skipping changes with multiple depotsLuke Diamand, Dec 19, 2015
  3. 2/3 git-p4: support multiple depot paths in p4 submitLuke Diamand, Dec 19, 2015
  4. 3/3 git-p4: reduce number of server queries for fetchesLuke Diamand, Dec 19, 2015
  5. Junio C HamanoDec 21, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.