git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv2 0/3] git-p4: fixing p4ChangesForPaths

From
Luke Diamand <luke@diamand.org>
Date
Dec 19, 2015, 09:39 UTC
Message-ID
<1450517980-1744-1-git-send-email-luke@diamand.org>

James Farwell found a bug in p4ChangesForPaths() when handling changes across multiple depot paths.

Sam Hocevar had already submitted a change to the same function to get P4 to do queries across all of the depot paths, in order to reduce server queries, which had the side effect of fixing James' problem.

This followup just fixes Sam's original fix to restore the behavior of p4ChangesForPaths() so that it returns a sorted list of changes. That fixes a failing a testcase.

Luke Diamand (1):
  git-p4: failing test case for skipping changes with multiple depots
Sam Hocevar (2):
  git-p4: support multiple depot paths in p4 submit
  git-p4: reduce number of server queries for fetches
 git-p4.py               | 55 +++++++++++++++++++++++++++----------------------
 t/t9818-git-p4-block.sh | 28 ++++++++++++++++++++++++-
 2 files changed, 57 insertions(+), 26 deletions(-)
-- 
2.6.2.474.g3eb3291
Next: Luke Diamand
Message 1 of 5 in “[PATCHv2 0/3] git-p4: fixing p4ChangesForPaths”
  1. Luke DiamandDec 19, 2015
  2. 1/3 git-p4: failing test case for skipping changes with multiple depotsLuke Diamand, Dec 19, 2015
  3. 2/3 git-p4: support multiple depot paths in p4 submitLuke Diamand, Dec 19, 2015
  4. 3/3 git-p4: reduce number of server queries for fetchesLuke Diamand, Dec 19, 2015
  5. Junio C HamanoDec 21, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.