git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] credential-store: don't pass strerror to die_errno()

From
SZEDER Gábor <szeder@ira.uka.de>
Date
Dec 16, 2015, 11:22 UTC
Message-ID
<1450264975-9760-1-git-send-email-szeder@ira.uka.de>
In-Reply-To
<1449138687-23675-1-git-send-email-szeder@ira.uka.de>
Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
---

v2 fixed this, but it fell on the floor, I suppose because of the maintainer switch. Anyway, I should have noticed it while the patch was still cooking, sorry.

 credential-store.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/credential-store.c b/credential-store.c
index fc67d16c1088..54c4e0473737 100644
--- a/credential-store.c
+++ b/credential-store.c
@@ -64,8 +64,7 @@ static void rewrite_credential_file(const char *fn, struct credential *c,
 		print_line(extra);
 	parse_credential_file(fn, c, NULL, print_line);
 	if (commit_lock_file(&credential_lock) < 0)
-		die_errno("unable to write credential store: %s",
-			  strerror(errno));
+		die_errno("unable to write credential store");
 }
 
 static void store_credential_file(const char *fn, struct credential *c)
-- 
2.7.0.rc0.37.g77d69b9
Previous: SZEDER GáborNext: Jeff King
Message 7 of 8 in “Make error message after failing commit_lock_file() less confusing”
  1. Make error message after failing commit_lock_file() less confusingSZEDER Gábor, Nov 30, 2015
  2. Jeff KingDec 1, 2015
  3. Junio C HamanoDec 2, 2015
  4. Eric SunshineDec 2, 2015
  5. SZEDER GáborDec 3, 2015
  6. Make error message after failing commit_lock_file() less confusingSZEDER Gábor, Dec 3, 2015
  7. credential-store: don't pass strerror to die_errno()SZEDER Gábor, Dec 16, 2015
  8. Jeff KingDec 16, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.