[PATCH 1/8] run-command: Fix early shutdown

From: Stefan Beller <sbeller@google.com>
Date: Oct 20, 2015, 22:43 UTC
Message-ID: <1445381030-23912-2-git-send-email-sbeller@google.com>
In-Reply-To: <1445381030-23912-1-git-send-email-sbeller@google.com>

The return value of `pp_collect_finished` indicates if we want to shutdown the parallel processing early. Have just one return path to return any accumulated results.

Signed-off-by: Stefan Beller <sbeller@google.com>
---
 run-command.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/run-command.c b/run-command.c
index ef3da27..b9363da 100644
--- a/run-command.c
+++ b/run-command.c
@@ -1077,7 +1077,7 @@ static int pp_collect_finished(struct parallel_processes *pp)
 	while (pp->nr_processes > 0) {
 		pid = waitpid(-1, &wait_status, WNOHANG);
 		if (pid == 0)
-			return 0;
+			break;
 
 		if (pid < 0)
 			die_errno("wait");

-- 
2.5.0.275.gbfc1651.dirty