git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC/PATCH 0/2] Submodules: refactoring the `module_list` function

From
Stefan Beller <sbeller@google.com>
Date
Jul 31, 2015, 23:09 UTC
Message-ID
<1438384147-3275-1-git-send-email-sbeller@google.com>
In-Reply-To
<1438301956-1658-1-git-send-email-sbeller@google.com>
Hi,

so eventually we want to have the whole Android project inside a git repository, which includes > 500 submodules for the different sub systems. To make that feasable we want to improve git-submodule for a huge set of submodules such as parallelizing `git submodule update`. As a first step I was toying around the `module_list` function as that is one key component for all the submodule operations. Also that part of the code is where the operations are split up to the different submodules, so that would be the natural place where we'd approach introducing threads later on.

This is an early RFC as it breaks the test suite. I do not remember ever interacting with pathspecs or cache entries before, so I'd appreciate some guiding comments. (Am I holding it wrong? Also the git code base seems large, it's easy to find new playgrounds :)

Thanks, Stefan

Stefan Beller (2):
  submodule: implement `module_list` as a builtin helper
  Testing the new code
 Makefile                    |  1 +
 builtin.h                   |  1 +
 builtin/submodule--helper.c | 99 +++++++++++++++++++++++++++++++++++++++++++++
 git-submodule.sh            | 25 +++++++++++-
 git.c                       |  1 +
 5 files changed, 126 insertions(+), 1 deletion(-)
 create mode 100644 builtin/submodule--helper.c
-- 
2.5.0.5.gf4cd9ae.dirty
Previous: Junio C HamanoNext: Stefan Beller
Message 3 of 15 in “add: remove dead code”
  1. add: remove dead codeStefan Beller, Jul 31, 2015
  2. Junio C HamanoJul 31, 2015
  3. 0/2 Submodules: refactoring the `module_list` functionStefan Beller, Jul 31, 2015
  4. 1/2 submodule: implement `module_list` as a builtin helperStefan Beller, Jul 31, 2015
  5. Junio C HamanoAug 1, 2015
  6. Stefan BellerAug 3, 2015
  7. Junio C HamanoAug 3, 2015
  8. submodule: implement `module_list` as a builtin helperStefan Beller, Aug 3, 2015
  9. Junio C HamanoAug 3, 2015
  10. Stefan BellerAug 3, 2015
  11. submodule: implement `module_list` as a builtin helperStefan Beller, Aug 3, 2015
  12. 2/2 Testing the new codeStefan Beller, Jul 31, 2015
  13. Junio C HamanoAug 1, 2015
  14. Stefan BellerAug 3, 2015
  15. Junio C HamanoAug 3, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.