git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 16/16] config.mak.uname: add MSVC No_SafeExeceptionHandler option

From
Philip Oakley <philipoakley@iee.org>
Date
Jul 19, 2015, 20:08 UTC
Message-ID
<1437336497-4072-18-git-send-email-philipoakley@iee.org>
In-Reply-To
<1437336497-4072-1-git-send-email-philipoakley@iee.org>

Microsoft flipped the Windows Safe Exception Handling default in VS2013 so that zlib became unacceptable to certain OS versions (Vista and subsequent 32-bit OS's) without the addition of the option -SAFESEH:NO.

Provide a switch to disable the Safe Exeption Handler when required.

The option ImageHasSafeExceptionHandlers for VS2013 is not available in earlier versions, so use the SAFESEH:NO linker flag. See https://msdn.microsoft.com/en-us/library/9a89h429.aspx for further details.

This has only had limited testing due to the lack of a suitable system.
Helped-by: Yue Lin Ho <b8732003@student.nsysu.edu.tw>
Signed-off-by: Philip Oakley <philipoakley@iee.org>
---
Junio/my discussion on reviews: http://marc.info/?l=git&m=143526063906215&w=2 (2015-06-25)
Patch series v1: https://github.com/msysgit/git/pull/318
Yue Lin Ho: https://github.com/msysgit/git/pull/318#issuecomment-81292918
---
 config.mak.uname | 9 +++++++++
 1 file changed, 9 insertions(+)
diff --git a/config.mak.uname b/config.mak.uname
index 943c439..1c27828 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -1,5 +1,9 @@
 # Platform specific Makefile tweaks based on uname detection
 
+# Define NO_SAFESEH if you need MSVC/Visual Studio to ignore the lack of
+# Microsoft's Safe Exception Handling in libraries (such as zlib).
+# Typically required for VS2013+/32-bit compilation on Vista+ versions.
+
 uname_S := $(shell sh -c 'uname -s 2>/dev/null || echo not')
 uname_M := $(shell sh -c 'uname -m 2>/dev/null || echo not')
 uname_O := $(shell sh -c 'uname -o 2>/dev/null || echo not')
@@ -385,6 +389,11 @@ ifeq ($(uname_S),Windows)
 	PTHREAD_LIBS =
 	lib =
 	BASIC_CFLAGS += -DPROTECT_NTFS_DEFAULT=1
+
+ifdef NO_SAFESEH
+	LDFLAGS += -SAFESEH:NO
+endif
+
 ifndef DEBUG
 	BASIC_CFLAGS += -GL -Os -MD
 	BASIC_LDFLAGS += -LTCG

-- 
2.4.2.windows.1.5.gd32afb6

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "Git for Windows" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Previous: Philip Oakley
Message 26 of 26 in “Make the msvc-build scripts work again”
  1. 00/16 Make the msvc-build scripts work againPhilip Oakley, Jul 19, 2015
  2. 01/16 perl/Makefile: treat a missing PM.stamp as if emptyPhilip Oakley, Jul 19, 2015
  3. 02/16 .gitignore: improve MSVC ignore patternsPhilip Oakley, Jul 19, 2015
  4. 03/16 .gitignore: ignore library directories created by MSVC VS2008 buildsystemPhilip Oakley, Jul 19, 2015
  5. 04/16 (msvc-build) Vcproj.pm: remove duplicate GUIDPhilip Oakley, Jul 19, 2015
  6. 05/16 engine.pl: fix error message (lib->link)Philip Oakley, Jul 19, 2015
  7. 06/16 engine.pl: Properly accept quoted spaces in filenamesPhilip Oakley, Jul 19, 2015
  8. 07/16 engine.pl: Fix i18n -o option in msvc buildsystem generatorPhilip Oakley, Jul 19, 2015
  9. 08/16 engine.pl: ignore invalidcontinue.obj which is known to MSVCPhilip Oakley, Jul 19, 2015
  10. Eric SunshineJul 20, 2015
  11. Philip OakleyJul 20, 2015
  12. 09/16 engine.pl: name the msvc buildsystem's makedry error filePhilip Oakley, Jul 19, 2015
  13. 10/16 engine.pl: delete the captured stderr file if emptyPhilip Oakley, Jul 19, 2015
  14. Eric SunshineJul 20, 2015
  15. Philip OakleyJul 20, 2015
  16. Eric SunshineJul 20, 2015
  17. Philip OakleyJul 20, 2015
  18. Eric SunshineJul 20, 2015
  19. 11/16 engine.pl: add debug line to capture the dry-runPhilip Oakley, Jul 19, 2015
  20. 12/16 engine.pl: provide more debug print statementsPhilip Oakley, Jul 19, 2015
  21. 13/16 Vcproj.pm: list git.exe first to be startup projectPhilip Oakley, Jul 19, 2015
  22. 14/16 vcbuild/readme: Improve layout and reference msvc-build scriptPhilip Oakley, Jul 19, 2015
  23. Philip OakleyJul 19, 2015
  24. 14/16 vcbuild/readme: Improve layoutPhilip Oakley, Jul 19, 2015
  25. 15/16 msvc-build: add complete Microsoft Visual C compilation scriptPhilip Oakley, Jul 19, 2015
  26. 16/16 config.mak.uname: add MSVC No_SafeExeceptionHandler optionPhilip Oakley, Jul 19, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.