[PATCH v2 09/16] engine.pl: name the msvc buildsystem's makedry error file
- From
Philip Oakley <philipoakley@iee.org>
- Date
- Jul 19, 2015, 20:08 UTC
- Message-ID
- <1437336497-4072-10-git-send-email-philipoakley@iee.org>
- In-Reply-To
- <1437336497-4072-1-git-send-email-philipoakley@iee.org>
Save the stderr from the dry MSVC make to a well named file for later review. Use 'msvc-build-makedryerrors.txt' which should be obvious as to its source, and is not ignored by 'git status'.
Signed-off-by: Philip Oakley <philipoakley@iee.org> --- fixed false mode change:- Junio's report (last line of) http://marc.info/?l=git&m=143524504500824 (2015-06-25),
The cause was probably an early 'commit --amend' during a rebase, and using the git gui to unstage the whole commit, then pick up and commit hunks one at a time. Unfortunately, on Msysgit/g4w core.filemode is false, so the execute bit was lost during the unstage, never noticed, and there's no simple way of adding it back.
Discussion on correcting file mode on msysgit/git4Windows is at https://groups.google.com/forum/#!topic/msysgit/zwH-qj0xR48 --- contrib/buildsystems/engine.pl | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/contrib/buildsystems/engine.pl b/contrib/buildsystems/engine.pl index 9db3d43..a6999b6 100755 --- a/contrib/buildsystems/engine.pl +++ b/contrib/buildsystems/engine.pl @@ -73,7 +73,10 @@ Running GNU Make to figure out build structure... EOM # Pipe a make --dry-run into a variable, if not already loaded from file -@makedry = `cd $git_dir && make -n MSVC=1 V=1 2>/dev/null` if !@makedry; +# Capture the make dry stderr to file for review (will be empty for a release build). + +my $ErrsFile = "msvc-build-makedryerrors.txt"; +@makedry = `cd $git_dir && make -n MSVC=1 V=1 2>$ErrsFile` if !@makedry; # Parse the make output into usable info parseMakeOutput();
-- 2.4.2.windows.1.5.gd32afb6 -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "Git for Windows" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.