Re: [PATCH v2] pull: handle --log=<n>
- From
Dennis Kaarsemaker <dennis@kaarsemaker.net>
- Date
- May 20, 2015, 08:11 UTC
- Message-ID
- <1432109506.18433.0.camel@kaarsemaker.net>
- In-Reply-To
- <xmqqegmcour4.fsf@gitster.dls.corp.google.com>
On di, 2015-05-19 at 19:19 -0700, Junio C Hamano wrote:
> Hopefully now you have some idea how your approach is problematic.
Yes, thanks for the thorough explanation!
Two more bad sideeffects, so two more reasons not to take this approach:
- test_must_fail tests might now fail for the wrong reason, undetectedly
("ref does not exist" instead of "can't handle ref")
- same for TODO tests-- Dennis Kaarsemaker www.kaarsemaker.net