git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-p4: Fix ocasional test failures in kill_p4d

From
Luke Diamand <luke@diamand.org>
Date
Apr 29, 2015, 21:26 UTC
Message-ID
<1430342769-20521-1-git-send-email-luke@diamand.org>

Running the git-p4 unit tests, I notice that the 'kill_p4d' test occasionally fails. This just terminates the p4d server, so in theory it should always succeed. The problem is especially noticeable when running multiple tests in parallel:

    $ make -C t T=t98*.sh -j50
That's annoying, as it makes it harder to test changes to git-p4.

It looks like p4d is sensitive to being killed ungracefully. Experimentally, I find that starting it with journalling disabled, and using 'p4 admin stop' rather than kill(1) makes the process much more reliable; I no longer see the intermittent failures.

Luke Diamand (1):
  git-p4: fix occasional test failure in kill_p4d
 t/lib-git-p4.sh | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)
-- 
2.3.4.48.g223ab37
Next: Luke Diamand
Message 1 of 2 in “git-p4: Fix ocasional test failures in kill_p4d”
  1. git-p4: Fix ocasional test failures in kill_p4dLuke Diamand, Apr 29, 2015
  2. git-p4: fix occasional test failure in kill_p4dLuke Diamand, Apr 29, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.