From: Luke Diamand Date: Wed, 29 Apr 2015 21:26:08 GMT Subject: [PATCH] git-p4: Fix ocasional test failures in kill_p4d Message-ID: <1430342769-20521-1-git-send-email-luke@diamand.org> Running the git-p4 unit tests, I notice that the 'kill_p4d' test occasionally fails. This just terminates the p4d server, so in theory it should always succeed. The problem is especially noticeable when running multiple tests in parallel: $ make -C t T=t98*.sh -j50 That's annoying, as it makes it harder to test changes to git-p4. It looks like p4d is sensitive to being killed ungracefully. Experimentally, I find that starting it with journalling disabled, and using 'p4 admin stop' rather than kill(1) makes the process much more reliable; I no longer see the intermittent failures. Luke Diamand (1): git-p4: fix occasional test failure in kill_p4d t/lib-git-p4.sh | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) -- 2.3.4.48.g223ab37