git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Freeing struct lock_file?

From
David Turner <dturner@twopensource.com>
Date
Apr 7, 2015, 01:12 UTC
Message-ID
<1428369163.3560.12.camel@ubuntu>
In-Reply-To
<xmqqfv8gg9bp.fsf@gitster.dls.corp.google.com>
On Fri, 2015-04-03 at 15:01 -0700, Junio C Hamano wrote:
Show 10 quoted lines
> David Turner <dturner@twopensource.com> writes:
> 
> > Why is it impossible to free struct lock_files?  I understand that they
> > become part of a linked list, and that there's an atexit handler that
> > goes over that list.  But couldn't we just remove them from the linked
> > list and then free them? 
> 
> I suspect that the code is worried about getting a signal, while it
> is manipulating the linked list, and then cause the atexit handler
> to walk a list that is in a broken state.

Actually, couldn't we just block signals with sigprocmask while manipulating the list?

Previous: brian m. carlson
Message 9 of 9 in “Freeing struct lock_file?”
  1. David TurnerApr 3, 2015
  2. Junio C HamanoApr 3, 2015
  3. David TurnerApr 4, 2015
  4. Torsten BögershausenApr 4, 2015
  5. David TurnerApr 6, 2015
  6. C99 (Was: Re: Freeing struct lock_file?)brian m. carlson, Apr 4, 2015
  7. Junio C HamanoApr 4, 2015
  8. brian m. carlsonApr 4, 2015
  9. David TurnerApr 7, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.