git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-add--interactive: return from list_and_choose if there is zero candidates

From
Alexander Kuleshov <kuleshovmail@gmail.com>
Date
Jan 22, 2015, 08:39 UTC
Message-ID
<1421915984-31207-1-git-send-email-kuleshovmail@gmail.com>

This patch introduce the check in list_and_choose() routine for the list. If list is empty just return.

It can be useful for example if user selects 'add untracked' and there are no untracked files, "Add untracked>>" opens. But it does not make sense in this case, because there are no untracked files.

Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
 git-add--interactive.perl | 5 +++++
 1 file changed, 5 insertions(+)
diff --git a/git-add--interactive.perl b/git-add--interactive.perl
index 94b988c..85b2fe7 100755
--- a/git-add--interactive.perl
+++ b/git-add--interactive.perl
@@ -519,6 +519,9 @@ sub error_msg {
 sub list_and_choose {
 	my ($opts, @stuff) = @_;
 	my (@chosen, @return);
+	if (!@stuff) {
+	    return @return;
+	}
 	my $i;
 	my @prefixes = find_unique_prefixes(@stuff) unless $opts->{LIST_ONLY};
 
@@ -729,6 +732,8 @@ sub add_untracked_cmd {
 	if (@add) {
 		system(qw(git update-index --add --), @add);
 		say_n_paths('added', @add);
+	} else {
+		print "No untracked files.\n";
 	}
 	print "\n";
 }
-- 
2.3.0.rc1.247.gb53aa6f.dirty
Message 1 of 1 in “git-add--interactive: return from list_and_choose if there is zero candidates”
  1. git-add--interactive: return from list_and_choose if there is zero candidatesAlexander Kuleshov, Jan 22, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.