[PATCH] git-add--interactive: return from list_and_choose if there is zero candidates

Alexander Kuleshov· Jan 22, 2015, 08:39 UTC · lore

This patch introduce the check in list_and_choose() routine for the list. If list is empty just return.

It can be useful for example if user selects 'add untracked' and there are no untracked files, "Add untracked>>" opens. But it does not make sense in this case, because there are no untracked files.

Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
 git-add--interactive.perl | 5 +++++
 1 file changed, 5 insertions(+)

Show changes to git-add--interactive.perl +5 −0

diff --git a/git-add--interactive.perl b/git-add--interactive.perl
index 94b988c..85b2fe7 100755
--- a/git-add--interactive.perl
+++ b/git-add--interactive.perl
@@ -519,6 +519,9 @@ sub error_msg {
 sub list_and_choose {
 	my ($opts, @stuff) = @_;
 	my (@chosen, @return);
+	if (!@stuff) {
+	    return @return;
+	}
 	my $i;
 	my @prefixes = find_unique_prefixes(@stuff) unless $opts->{LIST_ONLY};
 
@@ -729,6 +732,8 @@ sub add_untracked_cmd {
 	if (@add) {
 		system(qw(git update-index --add --), @add);
 		say_n_paths('added', @add);
+	} else {
+		print "No untracked files.\n";
 	}
 	print "\n";
 }

-- 
2.3.0.rc1.247.gb53aa6f.dirty

patchgit-add--interactive: return from list_and_choose if there is zero candidates