git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 4/5] t7610-mergetool: use test_config to isolate tests

From
David Aguilar <davvid@gmail.com>
Date
Oct 16, 2014, 05:30 UTC
Message-ID
<1413437404-23810-1-git-send-email-davvid@gmail.com>
In-Reply-To
<xmqqwq81ujlw.fsf@gitster.dls.corp.google.com>
Signed-off-by: David Aguilar <davvid@gmail.com>
---
This is a replacement patch for
"t7610-mergetool: prefer test_config over git config"
in da/mergetool-tests.
Changes since v1:

The changes are more surgical and the commit message mentions why we are using test_config.

 t/t7610-mergetool.sh | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/t/t7610-mergetool.sh b/t/t7610-mergetool.sh
index 1a15e06..4fec633 100755
--- a/t/t7610-mergetool.sh
+++ b/t/t7610-mergetool.sh
@@ -112,7 +112,7 @@ test_expect_success 'custom mergetool' '
 '
 
 test_expect_success 'mergetool crlf' '
-	git config core.autocrlf true &&
+	test_config core.autocrlf true &&
 	git checkout -b test2 branch1 &&
 	test_must_fail git merge master >/dev/null 2>&1 &&
 	( yes "" | git mergetool file1 >/dev/null 2>&1 ) &&
@@ -505,14 +505,12 @@ test_expect_success 'file with no base' '
 
 test_expect_success 'custom commands override built-ins' '
 	git checkout -b test14 branch1 &&
-	git config mergetool.defaults.cmd "cat \"\$REMOTE\" >\"\$MERGED\"" &&
-	git config mergetool.defaults.trustExitCode true &&
+	test_config mergetool.defaults.cmd "cat \"\$REMOTE\" >\"\$MERGED\"" &&
+	test_config mergetool.defaults.trustExitCode true &&
 	test_must_fail git merge master &&
 	git mergetool --no-prompt --tool defaults -- both &&
 	echo master both added >expected &&
 	test_cmp both expected &&
-	git config --unset mergetool.defaults.cmd &&
-	git config --unset mergetool.defaults.trustExitCode &&
 	git reset --hard master >/dev/null 2>&1
 '
 
-- 
2.1.2.453.g1b015e3
Previous: Junio C Hamano
Message 7 of 7 in “t7610-mergetool: use tabs instead of a mix of tabs and spaces”
  1. 1/5 t7610-mergetool: use tabs instead of a mix of tabs and spacesDavid Aguilar, Oct 15, 2014
  2. 2/5 t7610-mergetool: add missing && and remove commented-out codeDavid Aguilar, Oct 15, 2014
  3. 3/5 t7610-mergetool: add test cases for mergetool.writeToTempDavid Aguilar, Oct 15, 2014
  4. 4/5 t7610-mergetool: prefer test_config over git configDavid Aguilar, Oct 15, 2014
  5. 5/5 test-lib-functions: adjust style to match CodingGuidelinesDavid Aguilar, Oct 15, 2014
  6. Junio C HamanoOct 15, 2014
  7. 4/5 t7610-mergetool: use test_config to isolate testsDavid Aguilar, Oct 16, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.